Skip to content

GCP: upgrade GCSFuse to 1.3.0. #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

GCP: upgrade GCSFuse to 1.3.0. #2887

merged 1 commit into from
Dec 20, 2023

Conversation

concretevitamin
Copy link
Member

@concretevitamin concretevitamin commented Dec 19, 2023 •
edited
Loading

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
    • pytest tests/test_smoke.py::test_gcp_storage_mounts_with_stop
    • pytest tests/test_smoke.py::test_file_mounts --generic-cloud gcp
  • Backward compatibility tests:
    • Old cluster UP (1.0.1); upgrade to this PR; sky launch orig.yaml, ls -lthr /data
      • 1.0.1 still in use & works
    • Old cluster STOPPED (1.0.1); upgrade to this PR; sky start, ls -lthr /data
      • upgraded to 1.3.0 & works

romilbhardwaj
romilbhardwaj approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @concretevitamin! LGTM

@concretevitamin concretevitamin merged commit c0d2331 into master Dec 20, 2023
@concretevitamin concretevitamin deleted the upgrade-gcsfuse branch December 20, 2023 04:49
remyleone pushed a commit to remyleone/skypilot that referenced this pull request Dec 26, 2023
@concretevitamin @remyleone
GCP: upgrade GCSFuse to 1.3.0. (skypilot-org#2887)
f5fe523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romilbhardwaj romilbhardwaj romilbhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@concretevitamin @romilbhardwaj