-
Notifications
You must be signed in to change notification settings - Fork 633
[New Provisioner] New provisioner for k8s #3019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t into new-provisioner-k8s
@Michaelvll I've pushed some changes to:
Also ran some quick benchmarks to test provisioning speed compared to current master (Ray autoscaler based provisioning) using the default SkyPilot image:
I guess some slowdown is expected because of custom image support, which runs additional setup steps (running apt update etc), which negates the speed ups from using the new provisioner. Overall, provisioning time is roughly the same for single node, and we see some improvement for multi-node. Running smoke tests now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tests (both Kubernetes and general) pass! LGTM.
…t into new-provisioner-k8s
Updated docker images to 1) use the same base image as SkyPilot official docker image Tested with simple Also tested backward compatibility (i.e., new image also works with the old provisioner). Update - smoke tests pass, I have updated the image at |
It supports all the functionality of the original k8s support, and also supports custom image (adopted from #2599)
Special thanks to @landscapepainter for the excellent contribution to the custom image support PR #2599, which formulates this PR.
Co-authored-by: @landscapepainter
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py --kubernetes -k "not TestStorageWithCredentials"
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh