Skip to content

[docker] Add /dev/fuse for mounting containers in docker #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

Storage mounting was not working when running inside a docker container on the new provisioner. This PR fixes it and adds smoke tests.

Minimal repro:

resources:
  cloud: gcp
  image_id: docker:ubuntu:latest

file_mounts:
  /mymnt:
    source: s3://fah-public-data-covid19-cryptic-pockets #romileubucket2
    mode: MOUNT
  /mynotebooks:
    source: gs://romilb-notebooks/ #romileubucket2
    mode: MOUNT

setup: |
  echo hi

run: |
  ls -l /mynotebooks
  ls -l /mymnt
  echo run > /mynotebooks/hellotest.txt

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Smoke - pytest tests/test_smoke.py::test_docker_storage_mounts

@romilbhardwaj romilbhardwaj requested a review from cblmemo March 21, 2024 00:23
@romilbhardwaj romilbhardwaj merged commit acb49ee into master Mar 22, 2024
19 checks passed
@romilbhardwaj romilbhardwaj deleted the new_provisioner_docker_fuse branch March 22, 2024 20:22
@Michaelvll Michaelvll mentioned this pull request Jun 21, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants