[k8s] Add podip mode support for exposing ports #3445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Apr 25, 2024
sky/provision/kubernetes/utils.py
Outdated
Comment on lines
1279
to
1291
| def get_pod_name(cluster_name_on_cloud: str): | ||
| """Returns the pod name of the head pod for the given cluster name on cloud | ||
|
|
||
| Args: | ||
| cluster_name_on_cloud: Name of the cluster on cloud | ||
|
|
||
| Returns: | ||
| str: Pod name of the head pod | ||
| """ | ||
| # We could have iterated over all pods in the namespace and checked for the | ||
| # label, but since we know the naming convention, we can directly return the | ||
| # head pod name. | ||
| return f'{cluster_name_on_cloud}-head' |
There was a problem hiding this comment.
This seems a very shallow function and is only used once. Should we just have '{cluster_name_on_cloud}-head' in the place we call this function?
If we really want to keep this function, it might be better to rename it to get_head_pod_name instead, otherwise, it is a bit confusing for the multi-node case
There was a problem hiding this comment.
Good point - I've refactored to get_head_pod_name.
…o k8s_podip # Conflicts: # sky/provision/kubernetes/utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
podipmode for exposing ports on Kubernetes clusters. This is useful when the ports need to only be internally accessible from within the Kubernetes cluster and user wants to reduce the number of svcs running.Since ports exposed using
podipare not accessible from outside the cluster, we are not adding this mode to our main docs for now. Only covered in the config.yaml documentation, can add to main docs based on demand.Added after feedback from user.
Tested manually with
sky launch -c test2 --cloud kubernetes --ports 8888 -- 'python -m http.server 8888'->sky status --endpoints test2-> Access endpoint from within cluster.