Skip to content

[UX] A new look of SkyPilot console outputs #4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 100 commits into from
Oct 12, 2024
Merged

[UX] A new look of SkyPilot console outputs #4023

merged 100 commits into from
Oct 12, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Oct 1, 2024

This PR revamped the output of SkyPilot console output.

Launch

image

Managed Jobs

image image

Service

image

TODO:

  • Test logging for jobs and serve
  • Use detach run by default for jobs launch for more responsive feeling as serve does (for discussion; can be done in a future PR)

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Clouds with old provisioner
  • All smoke tests: pytest tests/test_smoke.py (except for test_tpu_vm_pod due to quota issue, TestStorageWithCredentials::test_aws_regions[eu-west-3] (and other 8 regions) due to permission issue).
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll
Copy link
Collaborator Author

Also is the space after the useful commands intended?

This new line was intended, as we have observed before that sometimes, if people ctrl-c or the program exited abnormally, users' terminal line will be shown in the same line as the last output, which looks messy. We added that newline to prevent those cases. Wdyt?

@Michaelvll Michaelvll enabled auto-merge October 12, 2024 22:25
@Michaelvll Michaelvll added this pull request to the merge queue Oct 12, 2024
Merged via the queue into master with commit d63497c Oct 12, 2024
20 checks passed
@Michaelvll Michaelvll deleted the ux-v3 branch October 12, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants