-
Notifications
You must be signed in to change notification settings - Fork 633
[UX] A new look of SkyPilot console outputs #4023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tian Xia <[email protected]>
Co-authored-by: Tian Xia <[email protected]>
Co-authored-by: Zongheng Yang <[email protected]>
This new line was intended, as we have observed before that sometimes, if people ctrl-c or the program exited abnormally, users' terminal line will be shown in the same line as the last output, which looks messy. We added that newline to prevent those cases. Wdyt? |
concretevitamin
approved these changes
Oct 12, 2024
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revamped the output of SkyPilot console output.
Launch
Managed Jobs
Service
TODO:
jobs launch
for more responsive feeling as serve does (for discussion; can be done in a future PR)Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
(except fortest_tpu_vm_pod
due to quota issue,TestStorageWithCredentials::test_aws_regions[eu-west-3]
(and other 8 regions) due to permission issue).pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh