Skip to content

[AWS] Adding custom process as an option for aws credentials #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

clayrosenthal
Copy link
Contributor

Adding the option for AWS credentials provided by custom process. This auth method already worked, it just wasn't recognized properly when checked.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
clayrosenthal Clay Rosenthal

Verified

This commit was signed with the committer’s verified signature.
clayrosenthal Clay Rosenthal
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clayrosenthal!

@romilbhardwaj romilbhardwaj merged commit 544c34e into skypilot-org:master Jan 9, 2025
18 checks passed
@clayrosenthal clayrosenthal deleted the aws-add-custom-process-cred branch January 9, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants