Fetch IBM instance profiles #5003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to fix some formatting issues. |
vvidovic
force-pushed
the
master
branch
4 times, most recently
from
90ebcb0 to
8d38f22
Compare
Create catalog (`ibm/vms.csv`) file from the IBM instance profiles fetched by the API. Unfortunately, it seems that currently, it is not possible to fetch pricing. There is the pricing API but it doesn't work for the `kind:instance.profile`. It works for the `kind:service` as described in the IBM documentation (https://cloud.ibm.com/docs/account?topic=account-getting-pricing-api).
All formatting and lint issues are cleared. Please check to include this code for manual IBM instance fetching purposes (pricing fetching is unfortunately not working by IBM API calls). |
Michaelvll
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create catalog (
ibm/vms.csv) file from the IBM instance profiles fetched by the API.Unfortunately, it seems that currently, it is not possible to fetch pricing. There is the pricing API but it doesn't work for the
kind:instance.profile. It works for thekind:serviceas described in the IBM documentation (https://cloud.ibm.com/docs/account?topic=account-getting-pricing-api).Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)