remove deprecations for 0.9.0

[cg505]

Closes #5211.

Key removals (for release notes):

• deprecated env vars starting with SKY_ are no longer supported. Use SKYPILOT_ env vars instead.
• old services from 0.7.0 (before [Serve] Add and adopt least load policy as default poicy. #4439) may not work
• kubernetes is no longer a valid region name - you must instead use the k8s context name

Tested (run the relevant ones):

• Code formatting: install pre-commit (auto-check on commit) or bash format.sh
• Any manual or new tests for this PR (please specify below)
• All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
• Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
• Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

[romilbhardwaj]

@aylei looks like there's a few deprecations in the helm chart we wanted to do before 0.9.0:

skypilot/charts/skypilot/templates/ingress-nodeport.yaml

Line 1 in 052e0ea

{{- /* TODO(aylei): remove this template in v0.9.0 release */ -}}

skypilot/charts/skypilot/values.yaml

Line 95 in e536958

# TODO(aylei): document the migration steps in v0.9.0 release note and remove these fields

Do you want to do those deprecations and add commits to this PR?

[aylei]

@aylei looks like there's a few deprecations in the helm chart we wanted to do before 0.9.0:

skypilot/charts/skypilot/templates/ingress-nodeport.yaml

Line 1 in 052e0ea

{{- /* TODO(aylei): remove this template in v0.9.0 release */ -}}

skypilot/charts/skypilot/values.yaml

Line 95 in e536958

# TODO(aylei): document the migration steps in v0.9.0 release note and remove these fields

Do you want to do those deprecations and add commits to this PR?

Sure

[aylei]

@romilbhardwaj After I reviewed the changes, I just modified the comment from 0.9.0 to 0.10.0. So that if a 0.8.0-nightly user upgrade to 0.9.0, he/she can see the error and migrate the values accordingly. And if users in 0.8.0-nightly want to upgrade to 0.10.0, we can guide them to upgrade to 0.9.0 first

[romilbhardwaj]

Thanks @aylei. Does the same also apply to

skypilot/charts/skypilot/values.yaml

Line 95 in e536958

# TODO(aylei): document the migration steps in v0.9.0 release note and remove these fields

? There's a TODO to add instructions to the release notes and deprecate, wondering if that should happen now or in 0.10.0.

[aylei]

@romilbhardwaj Good catch! the migrate guide is already there https://docs.skypilot.co/en/latest/reference/api-server/api-server-admin-deploy.html#migrate-from-legacy-nodeport-service, I will update the comment to be consistent

[cg505]

/smoke-test

[cg505]

/smoke-test

[cg505]

/quicktest-core

[cg505]

@romilbhardwaj feel free to approve & merge as needed, as long as buildkite tests look good