Skip to content

Conversation

NickyBoy89
Copy link

This PR adds a Github action to update all the vendor files, using the builtin vendor.sh script, and commits them directly to the repo

The workflow is set to run once every day at 12:00 PM

@smacker
Copy link
Owner

smacker commented Feb 2, 2022

hi @NickyBoy89 ! Thank you for the PR, looks great!

Something wrong with github, it doesn't let comment inline in the code but returns 500 errors, sorry about that.

Could you please clarify why do we need an empty rule for workflow_dispatch here?

on:
  repository_dispatch:
    types: rescrape
  workflow_dispatch:
  schedule:
    - cron: "0 0 * * *"

I also see commit Updated vendor files c926123 as a part of the PR. Could you please rebase your branch on master and make sure only new commits are present in the PR?

Thanks!

@NickyBoy89
Copy link
Author

Thank you for the review @smacker, the empty workflow_dispatch was so that you could run the workflow manually, although I have removed that

Also, I apologize for not being too familiar with Git, but how would I rebase the branch? I assume this means squash all the commits into one.

I'm also getting the 500 errors, so I think I'm going to have to open a new PR

@smacker
Copy link
Owner

smacker commented Feb 9, 2022

To rebase you would usually need to fetch that latest master from upstream and then run rebase command.
Here is a good description of how to do it: https://github.com/openedx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

Anyway, I pulled your changes to another branch and did some modifications here: #61

Please take a look.

@smacker smacker closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants