Skip to content

[WIP] UI memory router refactoring #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MarcMcIntosh
Copy link
Contributor

Backup of smallcloudai/refact-chat-js#323

Add routing library

Description

The pagesSlice / feature / component level routing has started to become a liability, this branch investigates on replacing it with an in memory router so that paths can be used to render pages.

Vscode currently occupies the native navigation, so a in memory solution had to be selected.

There's a fair amount of work to do with replacing the current navigation paths.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, only code improvements)
  • Documentation update

How to Test

  • Step 1:
  • Step 2:
  • ...

Screenshots (if applicable)

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated the documentation where necessary.

Linked Issues

https://refact.fibery.io/Software_Development/UI-chat-js-133#Task/TBD-SPIKE-normalise-navigation-453
https://refact.fibery.io/Software_Development/UI-chat-js-133#Task/SPIKE-Routing-804

Additional Notes

Base automatically changed from chat-updates-from-old-repo-180225 to main February 19, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant