Skip to content

Feature: Tools on off #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 79 commits into
base: dev
Choose a base branch
from
Open

Feature: Tools on off #775

wants to merge 79 commits into from

Conversation

alashchev17
Copy link
Contributor

UI is ready to be reviewed
LSP is still WIP

MDario123 added 30 commits May 13, 2025 13:57
@alashchev17 alashchev17 requested a review from MarcMcIntosh May 16, 2025 01:14
@alashchev17 alashchev17 self-assigned this May 16, 2025
});
}
})
.catch(alert);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is alert defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, need to remove that part :D

@alashchev17 alashchev17 requested a review from MarcMcIntosh May 16, 2025 11:12
@@ -379,18 +379,18 @@ startListening({
const state = listenerApi.getState();

// TBD: should the endpoint need tools?
const toolsRequest = listenerApi.dispatch(
toolsApi.endpoints.getTools.initiate(undefined),
const toolGroupsRequest = listenerApi.dispatch(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this request for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just replaced all occurrences of getTools, it's not used here, removed :)

const { agentic: _, ...remaining } = t.function;
return { ...t, function: { ...remaining } };
});
// let tools = await thunkApi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe to remove now?

// TODO: save tool use to state.chat
// if (toolUse && isToolUse(toolUse)) {
// dispatch(setToolUse(toolUse));
// TODO: should be safe to remove
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe to remove :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants