-
Notifications
You must be signed in to change notification settings - Fork 146
Feature: Tools on off #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…en waiting for response to improve UPP
…emoved duplicated code and left TODOs
}); | ||
} | ||
}) | ||
.catch(alert); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is alert defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, need to remove that part :D
refact-agent/gui/src/components/ChatForm/AgentCapabilities/useToolGroups.ts
Show resolved
Hide resolved
@@ -379,18 +379,18 @@ startListening({ | |||
const state = listenerApi.getState(); | |||
|
|||
// TBD: should the endpoint need tools? | |||
const toolsRequest = listenerApi.dispatch( | |||
toolsApi.endpoints.getTools.initiate(undefined), | |||
const toolGroupsRequest = listenerApi.dispatch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this request for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just replaced all occurrences of getTools
, it's not used here, removed :)
const { agentic: _, ...remaining } = t.function; | ||
return { ...t, function: { ...remaining } }; | ||
}); | ||
// let tools = await thunkApi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
safe to remove now?
// TODO: save tool use to state.chat | ||
// if (toolUse && isToolUse(toolUse)) { | ||
// dispatch(setToolUse(toolUse)); | ||
// TODO: should be safe to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
safe to remove :)
UI is ready to be reviewed
LSP is still WIP