SMTP without authentication, workaround touch API, use store theme settings for mail styling

[rhinterndorfer]

No description provided.

[muratcakir]

• Placement of closer is not optimal.
• Letter "X" is not a good choice for a closing button. Use an icon or the "×" char instead

[muratcakir]

There's a good reason why we didn't do that:

• It's not always guaranteed that every theme shares the same variables.
• E-Mails - due to some shitty clients - require a totally different styling approach

[rhinterndorfer]

What would be a better placement for a Closer?
I will check my e-Mail styling approach.

[muratcakir]

What would be a better placement for a Closer?

It just doesn't look good in the upper tabstrip. Besides, it squashes the tab labels and cuts them in other languages with longer labels. I have no idea where to place it in a hurry.

[rhinterndorfer]

The closer now uses times character and is placed outside the nav menu. While my test I have seen that when the screen width is very small the offcanvas-cart menu uses the whole width and therefore the closer is also needed to close the offcanvas-cart without the need of reloading the site. Please check my new suggestion and if you have any ideas to make it looking better please share it with me.

[muratcakir]

I would like to merge your pull request, but without the nav-closer stuff. Could you please remove it, we need a better approach for that. Actually, best way would be to fix the issue on convertible devices.

[rhinterndorfer]

I have removed the closer and have done a deeper look into the smartstore.offcanvas.js script which is responsible for the menu functionality. I have changed the hiding trigger event from "tap" to "click" and now it works on all device classes (mouse, touch, mixed). I have seen on small devices where the menu uses the whole width that you can close the menu with a swipe gesture. I think this is a good solution for small devices because I think they all have touch screens.

[rhinterndorfer]

Should I also revert the mail styling thing for the moment?

[muratcakir]

Should I also revert the mail styling thing for the moment?

Yes, please.

[rhinterndorfer]

I have reverted the mail styling thing.