Add PHPUnit tests for Smarty scopes and fix template source handling #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaKanDoR
commented
May 4, 2025
LaKanDoR
commented
- Introduced comprehensive PHPUnit tests for various Smarty scope functionalities, including append and assign scopes.
- Implemented tests for caching behavior and template inclusion with different scopes.
- Added error handling for undefined template variables and improved test coverage for caching mechanisms.
- Updated test results files to reflect the latest test outcomes and deprecations.
- Fixed issues related to argument counts in cache resource tests.
- Created missing template files for testing purposes.
- Introduced comprehensive PHPUnit tests for various Smarty scope functionalities, including append and assign scopes. - Implemented tests for caching behavior and template inclusion with different scopes. - Added error handling for undefined template variables and improved test coverage for caching mechanisms. - Updated test results files to reflect the latest test outcomes and deprecations. - Fixed issues related to argument counts in cache resource tests. - Created missing template files for testing purposes.
|
@LaKanDoR this is a massive PR, adding a lot of (seemingly unnecessary) files. I'm a big fan of more unit tests, especially for scope matters, but I also notice that this would drop support for a bunch of PHP versions (which we don't want). What are you trying to do here? What problem are you solving? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.