fix: favor endpointUrl over endpoint discovery when provided #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected ArtifactsChanged in size
|
lauzadis
approved these changes
Feb 13, 2025
| write("originalEndpoint.uri.copy { host = discoveredHost },") | ||
| write("originalEndpoint.headers,") | ||
| write("originalEndpoint.attributes,") | ||
| // Backported from https://github.com/smithy-lang/smithy-kotlin/pull/1221; replace when merging v1.5 to main |
There was a problem hiding this comment.
Should we add this as a subtask to our internal "v1.5 minor version bump" tracker?
There was a problem hiding this comment.
I added this mostly as a hint for the inevitable merge conflict. It's not necessarily a TODO or FIXME because resolving this will have to happen as part of the v1.5 release. I don't think adding this to a tracker is any more valuable then the other merge conflicts we anticipate.
0marperez
approved these changes
Feb 13, 2025
| write("originalEndpoint.uri.copy { host = discoveredHost },") | ||
| write("originalEndpoint.headers,") | ||
| write("originalEndpoint.attributes,") | ||
| // Backported from https://github.com/smithy-lang/smithy-kotlin/pull/1221; replace when merging v1.5 to main |
There was a problem hiding this comment.
Nit: This could be a TODO or FIXME for discoverability
There was a problem hiding this comment.
Answered in #1240 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Partially addresses aws/aws-sdk-kotlin#1413
Description of changes
This change updates endpoint resolution to favor
endpointUrlover endpoint discovery when both are provided/enabled. This allows callers to bypass endpoint discovery when using a custom endpoint.This change is backported from #1221 (slated for v1.5) but only includes non-breaking changes in codegen.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.