Skip to content

Conversation

sadiredd-sv
Copy link

Description of changes:
Merge Swift-client-runtime branch into master branch

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

phani-srikar and others added 30 commits June 10, 2020 11:11
chore: add swiftLint and codecov tooling to swift ClientRuntime
* feat(codegen): adding swift protocol generation and tests

* style(codegen): fixed ktlint issues

* test: fix tests to separate out pieces of protocol

* style(codegen): fix ktlint errors one last time i hope
* feat: add package manifest file generator

* feat: tools support to test code generated sdk builds

* fix: move swiftVersion to swiftSettings

* fix: dependecies available as pods and swift packages have empty package type
Copy link
Contributor

@kneekey23 kneekey23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just refactor folder structure after removal of smithy-kotlin and it's a go!

],
dependencies: [
.package(path: "~/Projects/Amplify/SwiftSDK/aws-crt-swift")
.package(path: "~/Documents/aws-crt-swift")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

circleci will fail I believe cuz you cloned to this path unless you changed to where you are cloning to in circleci?

Copy link
Author

@sadiredd-sv sadiredd-sv Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, reverting

@sadiredd-sv sadiredd-sv merged commit ac721b2 into master Nov 16, 2020
@kneekey23 kneekey23 deleted the swift-client-runtime branch March 20, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants