chore: Update Smithy to 1.59.0 #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Jun 17, 2025
| } | ||
| let lhsHeaders = lhs.access { $0 }.sorted() | ||
| let rhsHeaders = rhs.access { $0 }.sorted() | ||
| return lhsHeaders == rhsHeaders |
There was a problem hiding this comment.
Refactored to avoid simultaneously holding two locks.
jbelkins
commented
Jun 17, 2025
| writer.writeInline("nil") | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
We were incorrectly rendering the expected value when a collection or aggregate shape when it is supposed to be absent (i.e. "null" in the Smithy node tree for expected value.) This if-else handles that case.
jbelkins
commented
Jun 17, 2025
| // Don't write a prefix header over a specific header that was also written to this request. | ||
| // See the HttpEmptyPrefixHeadersRequestClient protocol tests on the REST protocols. | ||
| writer.write("guard !items.exists(name: \"$paramName\\(prefixHeaderMapKey)\") else { continue }") | ||
|
|
There was a problem hiding this comment.
New protocol tests specify that specific headers bound to names can overwrite prefix headers. This guard creates that behavior.
jbelkins
commented
Jun 17, 2025
| "let endpointParamsBlock = { [config] (context: \$N) in", | ||
| "}", | ||
| SmithyTypes.Context, | ||
| ) { |
sichanyoo
approved these changes
Jun 17, 2025
This was referenced Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates the SDK to Smithy 1.59.0 (latest version.)
Companion aws-sdk-swift PR: awslabs/aws-sdk-swift#1957
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.