Skip to content

fix: type compatibility between command schema and type transforms #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

fix: type compatibility between command schema and type transforms #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-news-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/types": patch
---

fix Command interface compatibility with type transformers
7 changes: 5 additions & 2 deletions packages/types/src/command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Handler, MiddlewareStack } from "./middleware";
import { MetadataBearer } from "./response";
import { OperationSchema } from "./schema/schema";

/**
* @public
Expand All @@ -14,7 +13,11 @@ export interface Command<
> extends CommandIO<InputType, OutputType> {
readonly input: InputType;
readonly middlewareStack: MiddlewareStack<InputType, OutputType>;
readonly schema?: OperationSchema;
/**
* This should be OperationSchema from @smithy/types, but would
* create problems with the client transform type adaptors.
*/
readonly schema?: any;

resolveMiddleware(
stack: MiddlewareStack<ClientInput, ClientOutput>,
Expand Down