Skip to content

do not merge - schema testing #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Draft

do not merge - schema testing #1704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb3430
schema testing
kuhe Sep 22, 2025
e12f3ab
client only
kuhe Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...main/java/software/amazon/smithy/typescript/codegen/schema/SchemaGenerationAllowlist.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ public abstract class SchemaGenerationAllowlist {

@Deprecated
public static boolean allows(String serviceShapeId, TypeScriptSettings settings) {
return ALLOWED.contains(serviceShapeId) && settings.generateSchemas();
return settings.generateClient();
}

public static boolean allows(ShapeId serviceShapeId, TypeScriptSettings settings) {
return ALLOWED.contains(serviceShapeId.toString()) && settings.generateSchemas();
return settings.generateClient();
}

public static void allow(String serviceShapeId) {
Expand Down
12 changes: 6 additions & 6 deletions ...degen/src/main/java/software/amazon/smithy/typescript/codegen/schema/SchemaGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,12 +521,12 @@ private void writeTraitsInContext(Shape context, Shape shape) {
TypeScriptWriter writer = getWriter(context.getId());
boolean useImportedStrings = !groupingIndex.isBaseGroup(context);

writer.write(
new SchemaTraitWriter(
shape, elision,
useImportedStrings ? store.useSchemaWriter(writer) : store
).toString()
);
String traitCode = new SchemaTraitWriter(
shape, elision,
useImportedStrings ? store.useSchemaWriter(writer) : store
).toString();

writer.write(traitCode.replace("$", "$$"));
}

/**
Expand Down
Loading