Skip to content

Fix secondary entrances data extraction #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marian-m12l
Copy link

Description

This PR fixes extraction of the "secondary entrances" data in the python script. Since the support of LM was added, secondary entrances data in range 0x5f800-0x5ffff are ignored, which results in transitioning to a broken "bonus level" whenever mario enters a pipe that should bring him back to the main level.

Will this Pull Request break anything?

No.

Suggested Testing Steps

  • Run game with g_runmode = RM_MINE
  • Enter level Yoshi's Island 1
  • Enter the 2nd blue pipe (under two yellow blocks)
  • Enter the pipe to go back to the main part of the level
  • Before fix: you get directed to a broken bonus level
  • After fix: you get back to the correct position, being shot out of a pipe in the main part of the level

yeticarus added a commit to yeticarus/smw-android that referenced this pull request Feb 10, 2025
yeticarus added a commit to yeticarus/smw-android that referenced this pull request Feb 10, 2025
yeticarus added a commit to yeticarus/smw-android that referenced this pull request Feb 10, 2025
Cleaner instructions in the readme to encourage using the android port to extract smw-asset.dat  (thus interating snesrev/smw#43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants