-
Notifications
You must be signed in to change notification settings - Fork 565
Closed
Labels
bugSomething isn't workingSomething isn't working
Milestone
Description
Describe the bug
Recently engine.io got whole new typescript code, but there are places that need for fixes.
One of it are arguments in Socket
methods send
and write
.
send(data: any, options: any, callback?: any): this
As You can see argument options
isn't optional, even that in method's body code suggets that it is: options = options || {}
A lot of projects sends data just by using socket.send(data)
, without any additional options, but now typescript shows error on these lines.
Engine.IO server version: 6.2.0
Solution
All we need is change options
argument to be optional in methods send
& write
for Socket
class.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working