Skip to content

Fix null payload when aborting connection #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Fix null payload when aborting connection #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ Server.prototype.attach = function (server, options) {

function abortConnection (socket, code) {
if (socket.writable) {
var message = Server.errorMessages.hasOwnProperty(code) ? Server.errorMessages[code] : code;
var message = Server.errorMessages.hasOwnProperty(code) ? Server.errorMessages[code] : (code || '');
var length = Buffer.byteLength(message);
socket.write(
'HTTP/1.1 400 Bad Request\r\n' +
Expand Down
9 changes: 9 additions & 0 deletions test/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ describe('server', function () {
});
});
});

it('should disallow connection that are rejected by `allowRequest`', function (done) {
listen({ allowRequest: function (req, fn) { fn(null, false); } }, function (port) {
var client = eioc('ws://localhost:%d'.s(port), { transports: ['websocket'] });
client.on('error', function () {
done();
});
});
});
});

describe('handshake', function () {
Expand Down