Skip to content

Fix for IE8 "Stack Overflow" Error. #458

@firejune

Description

@firejune

in socket.io.js(ver 0.7.5) line 3085:

  XHR.prototype.request = function (method) {
    var req = io.util.request(this.socket.isXDomain())
      , query = io.util.query(this.socket.options.query, + 't=' + +new Date);

to:

  XHR.prototype.request = function (method) {
    var req = io.util.request(this.socket.isXDomain())
      , query = io.util.query(this.socket.options.query, 't=' + +new Date);

boom!

Activity

denisu

denisu commented on Aug 11, 2011

@denisu

Awesome, it works. Thank you! ㅋㅋ

3rd-Eden

3rd-Eden commented on Aug 11, 2011

@3rd-Eden
Contributor

O_o that is one odd bug thats for finding it!

JohnMcLear

JohnMcLear commented on Aug 15, 2011

@JohnMcLear

Worked for us with Etherpad Lite, thanks! :)

JohnMcLear

JohnMcLear commented on Aug 15, 2011

@JohnMcLear

@3rd-Eden Is this bug closed and updated in the latest version? It's important for us :) Thanks!

denisu

denisu commented on Aug 15, 2011

@denisu

Yes its fixed in 0.7.9.

rauchg

rauchg commented on Sep 3, 2011

@rauchg
Contributor

This was already fixed

added 5 commits that reference this issue on Jul 4, 2024
8fdf4e2
1771590
fbda7e1
6045ccf
7995509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @rauchg@3rd-Eden@firejune@JohnMcLear@denisu

        Issue actions

          Fix for IE8 "Stack Overflow" Error. · Issue #458 · socketio/socket.io