-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
in socket.io.js(ver 0.7.5) line 3085:
XHR.prototype.request = function (method) {
var req = io.util.request(this.socket.isXDomain())
, query = io.util.query(this.socket.options.query, + 't=' + +new Date);
to:
XHR.prototype.request = function (method) {
var req = io.util.request(this.socket.isXDomain())
, query = io.util.query(this.socket.options.query, 't=' + +new Date);
boom!
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
denisu commentedon Aug 11, 2011
Awesome, it works. Thank you! ㅋㅋ
3rd-Eden commentedon Aug 11, 2011
O_o that is one odd bug thats for finding it!
JohnMcLear commentedon Aug 15, 2011
Worked for us with Etherpad Lite, thanks! :)
JohnMcLear commentedon Aug 15, 2011
@3rd-Eden Is this bug closed and updated in the latest version? It's important for us :) Thanks!
denisu commentedon Aug 15, 2011
Yes its fixed in 0.7.9.
rauchg commentedon Sep 3, 2011
This was already fixed
Fixes #458 #385
Merge pull request #276 from 3rd-Eden/bug/458
Merge pull request #458 from yhpark/master
Merge pull request #458 from nus-fboa2016-si/eslint-rebased
[fix] Add proper response when handleUpgrade fails (#458)