Skip to content

setting Socket.IO to log: false causes total failure in Manager.js #491

Closed
@perezd

Description

@perezd

L61 specifies that one can completely disable logging by setting the option log: false, upon doing so, Socket.IO will throw an exception about L116: this.log.info('socket.io started');

This is due to L140: if (this.disabled('log')) return;

this.log is undefined now, and undefined does not respond to info

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions