Fixes socketry/db-postgres#6 - Parsing of timestamps with microsecond precison #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Postgres can return timestamps with microsecond precision, and
db-postgres
is failing to handle these well.This is an attempt to fix that behaviour.
Notes:
nil
(as before), but maybe an explicit raise would be better?UTC
- only+HH:MM
format+HH
format (i.e. optional minutes)irb
:/Types of Changes
Contribution
I tested with the following values (collected from Postgres):
And I tested in Ruby 2.3 -> 3.1