Skip to content

Update for v23.06 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 29, 2023
Merged

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jun 24, 2022

Use only sofang packages

Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you not update PluginExampleConfig.cmake.in as well?

@hugtalbot
Copy link
Contributor

can I merge it @fredroy ?

@fredroy
Copy link
Contributor Author

fredroy commented Jun 6, 2023

can I merge it @fredroy ?

I suppose 😅

@alxbilger
Copy link
Contributor

@fredroy I am just not sure about the variables PLUGINEXAMPLE_HAVE_SOFA_GUI_QT and PLUGINEXAMPLE_HAVE_QT5_CORE as I don't understand where they come from. Can you have a look? We must merge this PR this week!

@alxbilger
Copy link
Contributor

Just a reminder @fredroy, otherwise we merge as is until any problem is raised.

@fredroy
Copy link
Contributor Author

fredroy commented Jun 29, 2023

@fredroy I am just not sure about the variables PLUGINEXAMPLE_HAVE_SOFA_GUI_QT and PLUGINEXAMPLE_HAVE_QT5_CORE as I don't understand where they come from. Can you have a look? We must merge this PR this week!

They come from sofa_find_package() macros.

@fredroy fredroy changed the title Update for v22.06 Update for v23.06 Jun 29, 2023
@alxbilger alxbilger merged commit 4bd0c70 into sofa-framework:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants