refactor(protocol): make undeployedPieceShapes serialisation nicer (#294) #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2020
Since the amount of colors is known and constants, we can avoid using a map altogether. This gives perfect null safety (because the corresponding indices are just there) (except xstream fails to serialise colors). This, in turn, makes the resulting xml much nicer
anarchuser
force-pushed
the
refactor/xstream
branch
from
7042b6b to
4f167fa
Compare
anarchuser
force-pushed
the
refactor/xstream
branch
from
30dc683 to
6a04793
Compare
SKoschnicke
requested changes
Sep 24, 2020
SKoschnicke
approved these changes
Sep 24, 2020
anarchuser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.