Skip to content

Conversation

j-piasecki
Copy link
Member

@j-piasecki j-piasecki commented May 16, 2022

Description

  • upgrade FabricExample to use React Native 0.69.0
  • fix GH compatibility with RN 0.69

Also adds mkdirp as a dev dependency to FabricExample because it's used by some RN script but it's not anywhere in the dependencies and CI was failing because of that.

Test plan

Build and check FabricExample

@j-piasecki j-piasecki marked this pull request as ready for review May 18, 2022 09:01
@j-piasecki j-piasecki linked an issue May 18, 2022 that may be closed by this pull request
Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless that's already done maybe worth submitting these patches to safe-area and screens repos?

@j-piasecki j-piasecki merged commit 850726a into main Jun 23, 2022
@j-piasecki j-piasecki deleted the @jpiasecki/upgrade-fabric-example-rn-69 branch June 23, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failed due to missing folly_json and folly_futures

2 participants