feat(iOS): add an option to prevent dismissal of external modals #2994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, dismissing a modal not owned by RNScreens may not be the expected behavior.
Changes
Added a new protocol,
RNSDismissibleModalProtocol
, which can be used by external libraries to control whether their modal should be dismissed when pushing a screen’s modal on top.When dismissing the top modal, the code now checks for conformance to this protocol. If the modal implements the protocol and
isDismissible
istrue
, the dismiss will not happen.In all other cases, the behavior of
setModalViewControllers
remains the same as before this change.Test code and steps to reproduce
Checklist