-
Notifications
You must be signed in to change notification settings - Fork 2.4k
instruction-padding: Remove solana-program dependency #7436
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,8 @@ mod entrypoint; | |
pub mod instruction; | ||
pub mod processor; | ||
|
||
pub use solana_program; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Breaking change, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah oops! I thought I pushed up the latest change, which re-exports the new solana crates. But yes, this is otherwise breaking There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess if it's a breaking change anyway, do we want to still have the re-exports? Or should we just do away with them? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It can't hurt in case someone needs to access it |
||
solana_program::declare_id!("iXpADd6AW1k5FaaXum5qHbSqyd7TtoN6AD7suVa83MF"); | ||
pub use { | ||
solana_account_info, solana_cpi, solana_instruction, solana_program_entrypoint, | ||
solana_program_error, solana_pubkey, | ||
}; | ||
solana_pubkey::declare_id!("iXpADd6AW1k5FaaXum5qHbSqyd7TtoN6AD7suVa83MF"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!