Skip to content

Update info callout titles #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

amirhhashemi
Copy link
Collaborator

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR addresses a bug where custom callout titles, such as :::tip[Custom Title], were not being applied. Additionally, it converts :::info callouts to :::note. My main reason for this change is that when a custom title is not set, I find "Note" to be much more meaningful than "Info." The term "Info" is very generic; everything can be considered a piece of information. For this reason, we often explicitly change the title of callouts to "Note" (e.g., :::info[Note]), and this PR eliminates the need for that.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit d54034b
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/684fd2c0a1c5dc00085c6b40
😎 Deploy Preview https://deploy-preview-1207--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@amirhhashemi amirhhashemi force-pushed the update-callout-title branch from df4632d to 05f5461 Compare June 16, 2025 08:04
@amirhhashemi amirhhashemi force-pushed the update-callout-title branch from 05f5461 to d54034b Compare June 16, 2025 08:15
@LadyBluenotes LadyBluenotes merged commit 82a8758 into solidjs:main Jun 18, 2025
7 checks passed
@amirhhashemi amirhhashemi deleted the update-callout-title branch June 19, 2025 03:52
amirhhashemi added a commit to amirhhashemi/solid-docs-next that referenced this pull request Jul 30, 2025
amirhhashemi added a commit to amirhhashemi/solid-docs-next that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants