Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions content/api/vision/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ The markers in the list have some useful attributes:
- `pixel_centre` - returns the location in pixels of the centre of the marker in the captured image.
- `cartesian` - returns details of the position of the marker in the [Cartesian](coordinates/#cartesian-coordinates) coordinate system.
- `spherical` - returns details of the position of the marker in a [spherical](coordinates/#spherical-coordinates) coordinate system.
- `orientation` - returns the rotation of the marker around its centre. See [Orientation](coordinates/#orientation) for its coordinate system.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the additional sentence just to link, could we word orientation into the initial one. Perhaps:

returns the [Orientation] of the marker around its centre.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5566007

- `polar` - *Deprecated*. Use the `spherical` attribute instead.

{{% notice tip %}}
Expand Down
15 changes: 14 additions & 1 deletion content/api/vision/coordinates.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,22 @@ robot, exactly 1 metre away.

{{% added_in update="2018-jan" feature="spherical coordinates" %}}

## Diagram
### Diagram

The following diagram shows the orientation of the Cartesian axes relative to
the camera as well as the angles which describe the spherical coordinate space.

![A diagram showing the coordinate spaces](/img/api/coordinate-spaces.svg)

## Orientation Coordinates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orientation isnt a coordinate system. I think this section warrants its own page


Orientation represents the rotation of a marker around the x, y, and z axes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why X, Y, Z are capitalised and x,y,z are not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, good catch

Rotations are applied in order of Z, Y, X.

The following table visually explains what positive and negative rotations represent.
| | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed in eb0f59e

|:-:|:-:|
| <img src="/img/api/coordinate-orientations/m45x0y0z.png?width=200px" style="margin:0"/> `rot_x_degrees = 45` | <img src="/img/api/coordinate-orientations/m-45x0y0z.png?width=200px" style="margin:0"/> `rot_x_degrees = -45` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using image tags here rather than the markdown format? I can't see that forcing the margin to 0 is really required here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default margin makes them very spaced out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, you're right, that's really annoying. I'll try and fix it with CSS some time!

| <img src="/img/api/coordinate-orientations/m0x45y0z.png?width=200px" style="margin:0"/> `rot_y_degrees = 45` | <img src="/img/api/coordinate-orientations/m0x-45y0z.png?width=200px" style="margin:0"/> `rot_y_degrees = -45` |
| <img src="/img/api/coordinate-orientations/m0x0y45z.png?width=200px" style="margin:0"/> `rot_z_degrees = 45` | <img src="/img/api/coordinate-orientations/m0x0y-45z.png?width=200px" style="margin:0"/> `rot_z_degrees= -45` |
| <img src="/img/api/coordinate-orientations/m0x0y0z.png?width=200px" style="margin:0"/> `0` in all axes |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.