Skip to content

Simplify compression when rebuilding the apt repo #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2018

Conversation

PeterJCLaw
Copy link
Contributor

As pointed out by @kierdavis in #22 (comment), python has an lzma module which provides xz compression meaning that we don't need to call out to another process for this.

@kierdavis
Copy link
Member

Changes appear fine to me. I'll aim to give this a test on monday evening.

@PeterJCLaw
Copy link
Contributor Author

There's a bunch of changes I've made to this repo recently which I don't think have been tested; I'll test that this still works shortly.

Do we have guidance on what/how to test runusb anywhere? (If not, I'll make some)

@kierdavis
Copy link
Member

There's a bunch of changes I've made to this repo recently which I don't think have been tested; I'll test that this still works shortly.

In that case I won't worry too much about testing this before merging it. It's occurred to me that we ought to have a stable branch in addition to master, or a stable master and unstable devel - anything that separates versions of repos that have been practically tested from those that haven't.

Do we have guidance on what/how to test runusb anywhere? (If not, I'll make some)

Not that I know of. I was just going to check if doing updates still works, but some notes on how one should test runusb would be useful (for future as well as for now).

@PeterJCLaw
Copy link
Contributor Author

I'd rather not get into stable vs develop etc. as it greatly complicates things. If we're going to have a testing phase we should expect that that passes before merging into master. We should also automated them...

I'll merge this shortly then create some tests.

@PeterJCLaw
Copy link
Contributor Author

(incidentally python/typeshed#1844 will add support for lzma in the typeshed)

@PeterJCLaw PeterJCLaw merged commit cc4c917 into master Jan 27, 2018
@PeterJCLaw PeterJCLaw deleted the use-python-lzma branch January 27, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants