This repository was archived by the owner on Jul 26, 2020. It is now read-only.
Rearrange pixel corner co-ordinates #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Previous API had marker corners ordered Clockwise from the bottom left. Apriltags orders them clockwise from the top left. This change converts the API to match Apriltags' output to reduce code complexity.
Adimote
force-pushed
the
rearrange-corner-markers
branch
from
aaa914e to
d3c66b0
Compare
|
@Adimote Are these relative to the marker or the image? That is, if the marker is upside down: is the first position value here that of the upper-leftmost corner within the image or the bottom-rightmost corner in the image? |
|
@PeterJCLaw yes that's correct |
|
@PeterJCLaw I've made it more clear in the comment |
PeterJCLaw
approved these changes
Jun 12, 2018
Turns out the pixel corner co-ordinates ordering was incorrect this fixes that.
|
Turns out I was completely incorrect about the ordering of the corners. That shows me for trusting my memory. I've now updated the ordering to match actual values |
PeterJCLaw
approved these changes
Jun 12, 2018
|
Speaking of testing -- the CI is highlighting some long lines. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearrange the marker corners to match that of apriltags