This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Fix assertion panic for type aliases to anonymous structs #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
changed the title
efritz
commented
Feb 24, 2021
| @@ -240,49 +240,86 @@ func TestIndexer(t *testing.T) { | |||
| if value := strings.ReplaceAll(hover.Result.Contents[2].Value, " ", "\t"); value != expectedUnderlyingType { | |||
| t.Errorf("incorrect hover text documentation. want=%q have=%q", expectedUnderlyingType, value) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
There's actually 3 tests here, should we break these out into different t.Runs?
efritz
commented
Feb 24, 2021
|
|
||
| signature, extra := typeString(f) | ||
| if signature != "type TestEqualsStruct = struct" { | ||
| t.Errorf("unexpected type string. want=%q have=%q", "type TestEqualsStruct struct", signature) |
There was a problem hiding this comment.
Should this fail? I'd expect this to hit typestring.go:50
There was a problem hiding this comment.
Oh the text is wrong here. I'll fix.
49 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133