First pass external dependency hovers #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
added
lib/com.sun.source
This was referenced Nov 11, 2020
Fetches a FileObject from source jar and walks the AST, comparing based on the stringified symbols (seems to work perfectly!) Returns the fetched javadoc comment and the tree element to be used for building the signature. May do this in the doc visitor instead of indexing visitor but w/e
Added ExternalDefinitionMeta, similar to DefinitionMeta but without a field for the definition range id and definition resultset id FileCollector passes the inferred sources to DocumentIndexers IndexingVisitor updated to not fully bail when finding refRange,defRange,defPath triplet, so we can use the refRange for emitting external hover Extracting stringifying JCMethodDecl so far, as used both when indexing local code and external definitions
Operation has a tendency to fail for obscure reasons (package name doesnt match path etc???) so we swallow exceptions and just fail for that file. This definitely needs to be improved
…xact file that threw
Saves all the overhead that our custom one needs for crawling the passed files
Strum355
force-pushed
the
nsc/ext-dep-hover
branch
from
afc21a8 to
a24c1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.