Add support for Yarn v3 #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
force-pushed
the
olafurpg/berry
branch
from
8609326 to
86cea8d
Compare
olafurpg
force-pushed
the
olafurpg/berry
branch
from
86cea8d to
1f7bc76
Compare
olafurpg
commented
Aug 26, 2022
src/CommandLineOptions.ts
Outdated
| .command('index') | ||
| .option('--cwd <path>', 'the working directory', process.cwd()) | ||
| .option('--yarn-workspaces', 'whether to index all yarn workspaces', false) | ||
| .option('--yarn-berry-workspaces', 'whether to index all yarn v3 workspaces', false) |
There was a problem hiding this comment.
@valerybugakov would it make sense to name this flag --yarn-v3-workspaces?
There was a problem hiding this comment.
@olafurpg, my rationale behind berry naming here is that this API was changed in the v2 and probably will be stable in v4 — it came with the berry rewrite of yarn. Open to other ideas, but tieing it to the specific yarn version can be misleading.
olafurpg
force-pushed
the
olafurpg/berry
branch
from
1f7bc76 to
c3322e8
Compare
valerybugakov
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
I ran
npx ts-node ~/dev/sourcegraph/scip-typescript/src/main.ts index --yarn-berry-workspaceslocally and it successfully indexed the Sourcegraph repo from this PR here https://github.com/sourcegraph/sourcegraph/pull/39728