Emit occurrences for string literals #184
Conversation
Previously, scip-typescript only emitted occurrences for identifiers. Now, we additionally emit occurrences for string literals so that features like "Go to definition" work with `import` statements and other locations where string literals reference actual symbols.
src/FileIndexer.ts
Outdated
| path | ||
| .basename(this.sourceFile.fileName) | ||
| .replace(/.tsx?$/, '') | ||
| .replace(/.jsx?/, '') |
There was a problem hiding this comment.
- Is it ever possible that we have files with the same base name but with different extensions? IIUC this happens with translation/conversion, but we will not index the generated files.
- I think you need to add
.d.ts,.cjsand.mjsextensions too. - Since the
.is inside the regex, it needs escaping, right? Or is this some reason why it doesn't need to be escaped here?
I'm wondering, instead of dropping the extension here, can we get the filename and include the extension when emitting the occurrence for the import instead? Any reason to prefer dropping the extension instead of doing that?
There was a problem hiding this comment.
This case should not happen since it's a fallback when moduleName is undefined, and I'm guessing it's always defined for ts.SourceFile
There was a problem hiding this comment.
My preference for dropping the extension was to best-effort mirror the output of moduleName, even if it doesn't handle all cases.
There was a problem hiding this comment.
Turns out moduleName was in fact undefined almost everywhere! I updated the logic to keep the file extension so that we don't treat d.ts/mjs/cjs extensions differently
2 participants
Previously, scip-typescript only emitted occurrences for identifiers. Now, we additionally emit occurrences for string literals so that features like "Go to definition" work with
importstatements and other locations where string literals reference actual symbols.Test plan
See the updated snapshot tests. I additionally manually verified that it works as expected on Sourcegraph https://sourcegraph.com/github.com/sourcegraph/scip-typescript@324cb332db75b3082fdbccc45a1a8e166d546b28/-/blob/src/FileIndexer.ts?L21:28&popover=pinned