This repository was archived by the owner on Sep 30, 2024. It is now read-only.
remove gitserver memory usage alert #12635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is always triggered. See https://www.bwplotka.dev/2019/golang-memory-monitoring.
emidoots
approved these changes
Aug 3, 2020
bobheadxi
suggested changes
Aug 3, 2020
monitoring/git_server.go
Outdated
| @@ -92,7 +92,6 @@ func GitServer() *Container { | |||
| Rows: []Row{ | |||
| { | |||
| sharedContainerCPUUsage("gitserver"), | |||
| sharedContainerMemoryUsage("gitserver"), | |||
There was a problem hiding this comment.
This doesn't get triggered (and probably shouldn't, since its threshold is at 99%) - I think we should leave this one in, and it would address @slimsag 's comment about being unable to see any memory stats
There was a problem hiding this comment.
Agree with keeping this as @bobheadxi said 👍
The issue I filed / was talking about is a bit separate (about alerting, not just being unable to see any memory stats).
|
Filed an issue: https://github.com/sourcegraph/sourcegraph/issues/12685 |
bobheadxi
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Some updates I made:
- add back container memory usage (current)
- add lower-bound 7d memory usage
- fix wording for provisioning solutions (!!!!)
https://github.com/sourcegraph/deploy-sourcegraph-dot-com/pull/3125 will remove the relevant silence
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is always triggered. See https://www.bwplotka.dev/2019/golang-memory-monitoring.