This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: fix panic in extracting JARs with absolute paths #24652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
added
team/graph
71 tasks
|
Notifying subscribers in CODENOTIFY files for diff bf7289e...e8a6f7e.
|
olafurpg
approved these changes
Sep 7, 2021
| @@ -368,14 +357,19 @@ func unzipJarFile(jarPath, destination string) (err error) { | |||
| // `file.Name` docstring. | |||
| continue | |||
| } | |||
| outputPath = path.Join(destination, file.Name) | |||
| if strings.HasPrefix(file.Name, "/") { | |||
| // Skip absolute paths. While they are extracted relative to `destination`, | |||
There was a problem hiding this comment.
Might be worth including a link to the upstream Go issue for more context.
Strum355
force-pushed
the
nsc/jar-extract-panic
branch
from
dd59b81 to
e8a6f7e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to golang/go#48085 (comment)