This repository was archived by the owner on Sep 30, 2024. It is now read-only.
ci: Set coverpkg to record dependency code coverage #4375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will now record coverage in all sourcegraph packages. Previously we only recorded the coverage per package test, so missed things like our DB tests covering the migrations bindata. We used to set this flag, but I think we lost it during our OSS process.
felixfbecker
approved these changes
Jun 5, 2019
|
It seems the reason we removed it is golang/go#30374. This will be fixed in go1.13, so we can reintroduce then. |
|
Filed https://github.com/sourcegraph/sourcegraph/issues/4376 to remember to try again. |
|
can we ignore the file for now then? |
|
how do you ignore it? Can you add the rule. |
|
I don't know, you have more experience with Go than me. In TS, you specify it in package.json under |
|
https://docs.codecov.io/docs/ignoring-paths can't do it like that in go, need to do it in codecov. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will now record coverage in all sourcegraph packages. Previously we only
recorded the coverage per package test, so missed things like our DB tests
covering the migrations bindata.
We used to set this flag, but I think we lost it during our OSS process.