Skip to content

Conversation

stephenf7072
Copy link
Contributor

A precursor to a series of simpler examples and/or a library to avoid the scary HAL function calls.

stephenf7072 and others added 6 commits July 24, 2020 09:09
Bringing up to date with release1.1.2
I hate to undo even a little bit of Adam's good work, but in the interests of a robust core, I think it's best the references to time.h are removed, and the Epoch set/get along with it.

RTC.cpp included <time.h>, which caused a compilation error when these are also included in code:
#include <Time.h>
#include <TimeLib.h>

Some possible issues with Window lack of case sensitivity, refer here: https://forum.arduino.cc/index.php?topic=451360.0

Also with time.h (or Time.h?) being an optional extra install library to the Arduino IDE, best to leave it out of the core, especially if it can cause compilation errors.
this keeps room around for the legacy BLE led example
Copy link
Contributor

@oclyke oclyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephenf7072!

@oclyke oclyke merged commit d9b3290 into sparkfun:master Jul 30, 2020
@stephenf7072
Copy link
Contributor Author

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants