Skip to content

Conversation

ziemek99
Copy link

@ziemek99 ziemek99 commented Nov 10, 2024

Apparently OSI webite was restructured a bit some time ago. Old links to license info return HTTP 301 redirects. While it's not a problem for a browser to follow such link, some kind of parser logic at SPDX erroneously detects such URL as "no longer live" when you see "Other web pages for this license" on SPDX website.

@goneall
Copy link
Member

goneall commented Nov 10, 2024

@ziemek99 - Thanks for pointing this out and proposing a solution

Rather than replacing the current OSI reference, I would suggest we add a new reference and keep the original so that tools the use the URL's to correlate license information won't break.

We'll end up with one live and one "not so live" URL. Note, this may appear unnecessary to human users, but for many tools it is quite important to correlate licenses with URLs that are no longer used.

@ziemek99
Copy link
Author

Rather than replacing the current OSI reference, I would suggest we add a new reference and keep the original so that tools the use the URL's to correlate license information won't break.

I suppose it only applies to files in src directory and not DOCS?

We'll end up with one live and one "not so live" URL.

Is there any required order to keep? For aesthetic reasons I'd like to keep "not so live" URLs under the live ones. If that'd break compatibility, though, I can keep the order of the previous entries and add current URLs underneath.

Another (better) solution would be fixing the parser logic so it follows any HTTP redirects and doesn't mark these URLs as no longer live.

@goneall
Copy link
Member

goneall commented Nov 11, 2024

Rather than replacing the current OSI reference, I would suggest we add a new reference and keep the original so that tools the use the URL's to correlate license information won't break.

I suppose it only applies to files in src directory and not DOCS?

Correct - only the src

We'll end up with one live and one "not so live" URL.

Is there any required order to keep? For aesthetic reasons I'd like to keep "not so live" URLs under the live ones. If that'd break compatibility, though, I can keep the order of the previous entries and add current URLs underneath.

I don't think order matters.

Another (better) solution would be fixing the parser logic so it follows any HTTP redirects and doesn't mark these URLs as no longer live.

Possibly - Although it is nice having the correct (non-redirected) URLs added for 2 reasons:

  • Improves the correlation of license identifications since it will identify licenses with the new location
  • The redirect may go away someday and having the "early warning" with the redirects may be helpful

Flagging these on the website gives us a chance to add the new URL. There may be a better way to flag them, but this did result in an very welcome update to the src URLs. Again - thanks for the PR and noticing the change.

@xsuchy
Copy link
Collaborator

xsuchy commented Nov 14, 2024

Otherwise LGTM.

@xsuchy
Copy link
Collaborator

xsuchy commented Dec 20, 2024

@ziemek99 Can you update the PR with requested change pls?

@swinslow
Copy link
Member

Holding for 3.27.0, I'd like to take a closer look at this given the number of files it's touching.

@swinslow swinslow added this to the 3.27.0 milestone Dec 30, 2024
@xsuchy
Copy link
Collaborator

xsuchy commented Mar 4, 2025

@ziemek99 Can you please update the PR?

@swinslow swinslow modified the milestones: 3.27.0, 3.28.0 Jul 1, 2025
@xsuchy
Copy link
Collaborator

xsuchy commented Oct 15, 2025

@swinslow LGTM, do you still want to review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants