-
Notifications
You must be signed in to change notification settings - Fork 342
Fix URLs to OSI website #2616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix URLs to OSI website #2616
Conversation
@ziemek99 - Thanks for pointing this out and proposing a solution Rather than replacing the current OSI reference, I would suggest we add a new reference and keep the original so that tools the use the URL's to correlate license information won't break. We'll end up with one live and one "not so live" URL. Note, this may appear unnecessary to human users, but for many tools it is quite important to correlate licenses with URLs that are no longer used. |
I suppose it only applies to files in
Is there any required order to keep? For aesthetic reasons I'd like to keep "not so live" URLs under the live ones. If that'd break compatibility, though, I can keep the order of the previous entries and add current URLs underneath. Another (better) solution would be fixing the parser logic so it follows any HTTP redirects and doesn't mark these URLs as no longer live. |
Correct - only the
I don't think order matters.
Possibly - Although it is nice having the correct (non-redirected) URLs added for 2 reasons:
Flagging these on the website gives us a chance to add the new URL. There may be a better way to flag them, but this did result in an very welcome update to the |
f38002f
to
d0300ec
Compare
Otherwise LGTM. |
@ziemek99 Can you update the PR with requested change pls? |
Holding for 3.27.0, I'd like to take a closer look at this given the number of files it's touching. |
@ziemek99 Can you please update the PR? |
@swinslow LGTM, do you still want to review it? |
Apparently OSI webite was restructured a bit some time ago. Old links to license info return HTTP 301 redirects. While it's not a problem for a browser to follow such link, some kind of parser logic at SPDX erroneously detects such URL as "no longer live" when you see "Other web pages for this license" on SPDX website.