Skip to content

Conversation

chase-crumbaugh
Copy link
Member

Now that http_tools is unused, we can remove it.

Also makes tool_urn columns NOT NULL

Queries showing that every toolset has a toolset_version and every http_tool/prompt_template has an urn
CleanShot 2025-10-07 at 10 32 43@2x

@chase-crumbaugh chase-crumbaugh requested a review from a team as a code owner October 7, 2025 17:33
Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: c56fbd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
gram Ready Ready Preview Comment Oct 10, 2025 5:53pm
gram-landing-redirect Ready Ready Preview Comment Oct 10, 2025 5:53pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
gram-docs Skipped Skipped Oct 10, 2025 5:53pm

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Squawk Report

🚒 2 violations across 1 file(s)


server/migrations/20251010175120_drop-http-tool-names.sql

-- Modify "http_tool_definitions" table
ALTER TABLE "http_tool_definitions" ALTER COLUMN "tool_urn" SET NOT NULL;
-- Modify "prompt_templates" table
ALTER TABLE "prompt_templates" ALTER COLUMN "tool_urn" SET NOT NULL;
-- Modify "toolsets" table
ALTER TABLE "toolsets" DROP CONSTRAINT "toolsets_http_tool_names_check", DROP COLUMN "http_tool_names";

🚒 Rule Violations (2)

server/migrations/20251010175120_drop-http-tool-names.sql:1:0: warning: adding-not-nullable-field

   1 | -- Modify "http_tool_definitions" table
   2 | ALTER TABLE "http_tool_definitions" ALTER COLUMN "tool_urn" SET NOT NULL;

  note: Setting a column NOT NULL blocks reads while the table is scanned.
  help: Use a check constraint instead.

server/migrations/20251010175120_drop-http-tool-names.sql:3:1: warning: adding-not-nullable-field

   3 | -- Modify "prompt_templates" table
   4 | ALTER TABLE "prompt_templates" ALTER COLUMN "tool_urn" SET NOT NULL;

  note: Setting a column NOT NULL blocks reads while the table is scanned.
  help: Use a check constraint instead.

📚 More info on rules

⚡️ Powered by Squawk (1.6.1), a linter for PostgreSQL, focused on migrations

Copy link
Contributor

@qstearns qstearns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sick

@vercel vercel bot temporarily deployed to Preview – gram-docs October 10, 2025 17:51 Inactive
@chase-crumbaugh chase-crumbaugh merged commit 93b1815 into main Oct 10, 2025
14 of 15 checks passed
@chase-crumbaugh chase-crumbaugh deleted the chase/urns6 branch October 10, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants