Skip to content

Conversation

chrisinmtown
Copy link
Contributor

The recent switch from setup.py to pyproject.toml omitted dependency packaging

Fixes #2085

Changes proposed in this pull request:

  • Restore package packaging to main project dependencies

@chrisinmtown chrisinmtown force-pushed the 2085-add-packaging branch 2 times, most recently from 1fac203 to 782d126 Compare October 6, 2025 11:33
@chrisinmtown chrisinmtown changed the title (v2) Add missing dependency packaging at min version 20 (v2) Add missing dependency packaging at min version 21 Oct 6, 2025
@chrisinmtown chrisinmtown changed the title (v2) Add missing dependency packaging at min version 21 (v2) Add missing dependency packaging at min version 22 Oct 6, 2025
The recent switch from setup.py to pyproject.toml omitted dependency `packaging`

Fixes: spec-first#2085
@chrisinmtown
Copy link
Contributor Author

Sorry for the churn. The current version of poetry seems to require the very latest version of packaging, which is 25. The v2 branch previously asserted minimum version 20 but that version lacks packaging.licenses and packaging.metadata, so poetry chokes when that version is installed as part of a py39-min run.

@chrisinmtown chrisinmtown changed the title (v2) Add missing dependency packaging at min version 22 (v2) Add missing dependency packaging at min version 25 Oct 6, 2025
@chrisinmtown
Copy link
Contributor Author

@RobbeSneyders @Ruwann would one of you please merge this PR then tag/trigger a workflow to release version 2.16.0rc1? I promise to test it immediately.

@chrisinmtown
Copy link
Contributor Author

chrisinmtown commented Oct 13, 2025

@Ruwann and @RobbeSneyders I'm really baffled at the delay here. The 2.15.0 release is broken, I opened this PR immediately after the problem was reported with a simple fix. That was over one week ago already. Would you please comment?

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not been involved in the release of 2.15, and as previously stated multiple times, am not interested in the ongoing maintenance of it.

Approving this based on @chrisinmtown's testing and analysis of the issue.

@RobbeSneyders RobbeSneyders merged commit 7c087f4 into spec-first:v2 Oct 13, 2025
8 checks passed
@RobbeSneyders
Copy link
Member

@chrisinmtown
Copy link
Contributor Author

Thank you for merging this and thank you for creating the release candidate! I will test it shortly.

@chrisinmtown
Copy link
Contributor Author

chrisinmtown commented Oct 13, 2025

Thank you again, this RC passes my tests:

  • Create and activate a new venv
  • Install the RC via pip3 install --pre connexion==2.15.1rc1
  • Launch connexion server on a simple YAML file pip3 install --pre connexion==2.15.1rc1
  • Observe that the server starts without complaint ModuleNotFoundError: No module named 'packaging' (which is what happens for 2.15.0)

@chrisinmtown
Copy link
Contributor Author

Please say what is required to promote 2.15.1 from RC to a normal release. Do you want additional commenters, approvers or something?

@RobbeSneyders
Copy link
Member

Your review is fine. I will release it.

@chrisinmtown
Copy link
Contributor Author

Your review is fine. I will release it.

Thanks, I'm glad to hear it, please do release this patch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants