-
-
Notifications
You must be signed in to change notification settings - Fork 778
(v2) Add missing dependency packaging at min version 25 #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1fac203
to
782d126
Compare
782d126
to
c79e388
Compare
The recent switch from setup.py to pyproject.toml omitted dependency `packaging` Fixes: spec-first#2085
c79e388
to
75732d7
Compare
Sorry for the churn. The current version of |
@RobbeSneyders @Ruwann would one of you please merge this PR then tag/trigger a workflow to release version 2.16.0rc1? I promise to test it immediately. |
@Ruwann and @RobbeSneyders I'm really baffled at the delay here. The 2.15.0 release is broken, I opened this PR immediately after the problem was reported with a simple fix. That was over one week ago already. Would you please comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not been involved in the release of 2.15, and as previously stated multiple times, am not interested in the ongoing maintenance of it.
Approving this based on @chrisinmtown's testing and analysis of the issue.
Pre-release here https://github.com/spec-first/connexion/releases/tag/2.15.1rc1 |
Thank you for merging this and thank you for creating the release candidate! I will test it shortly. |
Thank you again, this RC passes my tests:
|
Please say what is required to promote 2.15.1 from RC to a normal release. Do you want additional commenters, approvers or something? |
Your review is fine. I will release it. |
Thanks, I'm glad to hear it, please do release this patch version. |
The recent switch from setup.py to pyproject.toml omitted dependency
packaging
Fixes #2085
Changes proposed in this pull request:
packaging
to main project dependencies