Fix spec clone method and usage of raw vs resolved spec #2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2025
|
I would like to suggest adding a test for the |
RobbeSneyders
force-pushed
the
bugfix/swagger-ui-clone
branch
from
ae9df80 to
8adef16
Compare
|
Thanks @chrisinmtown, I expanded the test to include a clone step and reevaluate the cloned specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced in #2002, and the original issue #2002 was trying to address.
The original issue was that a cloned spec did not have properly resolved references. #2002 fixed this incorrectly by cloning the resolved spec, while the
Specinitializer expects a raw spec.This PR fixes this by cloning the raw spec, and passing the
base_urirequired to resolve it along to the initializer of the newSpecinstance.The swagger ui was also updated to use the resolved spec instead of the raw spec.
Supersedes:
#1889
#2080
Fixes:
#1890
#1909
#2028
#2029