Skip to content

Remove Python 3.4 #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Remove Python 3.4 #990

merged 4 commits into from
Jul 9, 2019

Conversation

kornicameister
Copy link
Contributor

Fixes #977 .

Changes proposed in this pull request:

  • remove Python 3.4 support
  • upgrade Python version in docs
  • remove backport import to HttpStatus

@kornicameister kornicameister changed the title Eol 34 Remove Python 3.4 Jul 7, 2019
@kornicameister
Copy link
Contributor Author

@hjacobs question still remain, should we drop old 2.7 as well ?
Dropping older python and starting with 3.5 would open up possibility to enhance codebase with mypy and typing which I could do :)

@kornicameister
Copy link
Contributor Author

I believe pytest-dev/pytest#5532 contains reason for failure.

@kornicameister
Copy link
Contributor Author

I've created an issue here: #991
I think that before any actions are taken, that ought be taken care of.

@kornicameister
Copy link
Contributor Author

@hjacobs perhaps, if you have time, you can take a look at this one here.

@hjacobs
Copy link
Contributor

hjacobs commented Jul 9, 2019

Thanks!

@hjacobs
Copy link
Contributor

hjacobs commented Jul 9, 2019

👍

@hjacobs hjacobs merged commit 123c5c9 into spec-first:master Jul 9, 2019
@kornicameister kornicameister deleted the eol_34 branch July 9, 2019 11:57
@kornicameister
Copy link
Contributor Author

Ok, guess that means we stick with 2.7 for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire EOL Python 3.4
2 participants