You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The rendered html shows errors because the relative URL of the include points to files that don't exist.
Expected behavior (e.g., it shouldn't crash):
The included files should render
Optional, steps to reproduce:
Add a data-include attribute that includes a local file, merge it in.
Verify that the merge is in the current rendering (github.io)
Make a new branch, somewhere.
Change a file. Commit that to the new branch
Make a PR to merge new branch
Click on the preview or diff link in the PR review
You'll note that the data-includes do not get rendered in the preview.
The underlying cause is that the relative URL takes on the base of the preview, which isn't the branch.
I don't know how the preview and diff functions are configured, but it seems that code could set the base using a URL that points to the branch that is being merged in.
Are those preview and diff functions under the ReSpec umbrella or something else?
The text was updated successfully, but these errors were encountered:
Description of problem
When using data-include, it fails to render in Github previews and diffs.
URL to affected spec or repo:
w3c/vc-use-cases#145
What happened (e.g., it crashed)?:
The rendered html shows errors because the relative URL of the include points to files that don't exist.
Expected behavior (e.g., it shouldn't crash):
The included files should render
Optional, steps to reproduce:
You'll note that the data-includes do not get rendered in the preview.
The underlying cause is that the relative URL takes on the base of the preview, which isn't the branch.
I don't know how the preview and diff functions are configured, but it seems that code could set the base using a URL that points to the branch that is being merged in.
Are those preview and diff functions under the ReSpec umbrella or something else?
The text was updated successfully, but these errors were encountered: