Bona fide shopper #145
Merged
Bona fide shopper #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KDean-GS1 When I tried to read the Diff, none of the use cases are visible. |
|
@David-Chadwick — The Diff (and the Preview) are both broken. This is an issue with the PR-Preview tools. I don't believe @KDean-GS1 can do anything about it. Try reviewing the source. |
TallTed
reviewed
Jun 29, 2023
David-Chadwick
approved these changes
Jun 30, 2023
|
@David-Chadwick @TallTed I was able to get the preview working by injecting a base for this particular PR. We'll have to remove that before merging, but at least the preview link should work now. I've also submitted an issue at the repo for the PR Preview library that is causing this problem: tobie/pr-preview#144 |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
This looks great. I'll take the base tag out and then merge. We can follow up with @David-Chadwick about whether or not we've addressed #127 in that issue. |
|
Yes its fine with me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from #127 and replaces that request. Use case proposed by @David-Chadwick.
Preview | Diff