Skip to content

Sphinx.add_js_file(): replace None filename with '' before passing to HTML builder #13402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2025
Merged

Sphinx.add_js_file(): replace None filename with '' before passing to HTML builder #13402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d900c3
Sphinx.add_js_file(): replace None filename with '' before passing to…
mitya57 Mar 2, 2025
b5043f5
Update
AA-Turner Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Bugs fixed
----------

* #13392: Fix argument type for ``jieba.load_userdict()``.
* #13402: Ensure inline ``<script>`` tags are written exactly once.

Testing
-------
1 change: 1 addition & 0 deletions sphinx/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,6 +1507,7 @@ def add_js_file(
elif loading_method == 'defer':
kwargs['defer'] = 'defer'

filename = filename or ''
self.registry.add_js_file(filename, priority=priority, **kwargs)
with contextlib.suppress(AttributeError):
self.builder.add_js_file( # type: ignore[attr-defined]
Expand Down