[WIP] Do not allow untyped calls anywhere in the mypy config #13699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtheturtle
commented
Jun 25, 2025
| @@ -102,14 +103,13 @@ def _check(name, input, id_dict, output, key, as_text_output): | |||
| # except NoOldIdError: | |||
| # id_actual.append(None) | |||
|
|
|||
| res = [True] | |||
There was a problem hiding this comment.
This was redefining a variable, so I just renamed it here to create a new variable.
adamtheturtle
force-pushed
the
untyped-call
branch
from
f7fa3ab to
a0e8db1
Compare
adamtheturtle
commented
Jun 25, 2025
| for i in range(1, _max_id + 1): | ||
| res.append(id_expected[i] == id_actual[i]) | ||
| res_bools = [True] | ||
| res_bools.extend(id_expected[i] == id_actual[i] for i in range(1, _max_id + 1)) |
There was a problem hiding this comment.
ruff made/required this change
adamtheturtle
force-pushed
the
untyped-call
branch
from
a0e8db1 to
807e144
Compare
adamtheturtle
force-pushed
the
untyped-call
branch
from
807e144 to
7901b72
Compare
adamtheturtle
changed the title
adamtheturtle
force-pushed
the
untyped-call
branch
from
9bb9adf to
3d9813d
Compare
|
@adamtheturtle is this ready? MyPy passes. |
|
@AA-Turner I kept this as WIP as it adds type ignores that I think can be avoided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For everything other than the simplest changes, I decided to add
type: ignorecomments rather than fixing the underlying issues. This adds 8 type ignores, with the trade-off that now a lot more of the relevant files is type checked.